Allow passing selected model to Configuration.check_consistent#45
Conversation
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Looks good! One small note, and be aware that this PR will conflict with #40 (but should be easy to resolve once one is merged)
|
|
||
|
|
||
| @pytest.fixture | ||
| def config_consistent_partial_resources() -> Configuration: |
There was a problem hiding this comment.
I usually prefer to keep test data close to the tests where they're used (i.e. define this fixture in test_configuration.py), and only move it to a shared conftest when it's used in multiple test files.
I'm also fine to keep it like this though!
There was a problem hiding this comment.
Yeah, that's a good point. The whole test_configuration.py is set up like this though, so maybe better to make a separate PR for that, where we change everything in one go?
LourensVeen
force-pushed
the
issue_41_check_resources_selected_model_only
branch
from
f0402e3 to
4e7dde8
Compare
LourensVeen
force-pushed
the
issue_41_check_resources_selected_model_only
branch
from
4e7dde8 to
5c4ab56
Compare
|
Another rebase to cover the merger of #44, and I'm going to merge this. I'll make a separate PR for the conftest refactor (and maybe just move the consistency checks into a separate file...) |
2 participants
This adds a parameter to
Configuration.check_consistentwith which the selected model can be passed. When checking whether the configuration is runnable, this will then only check whether that model has resources, and ignore missing resources for any other root models defined.Addresses #41.